Edit to respond to your edit: In my view the "see your papers" portion of the law is not likely to be ruled facially unconstitutional but will lead to civil rights violations in enforcement of it. The constitutional question doesn't really interest me that much. Lots of bad laws are Constitutional. That doesn't make them good laws.
But no or, at the most, few good laws are unconstitutional.